Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss 69 - Implement GETEX #101

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Iss 69 - Implement GETEX #101

merged 5 commits into from
Sep 6, 2024

Conversation

osteensco
Copy link
Contributor

addresses #69

  • Adds getex command
  • Adds GetEx method to generic API
  • Adds new struct GetExOptions
  • Minor fix to handleExpire and handleExpireAt functions
    • these would always assign and reassign the variable expireAt unnecessarily in the case of pexpire and pexpireat
  • Fixed inline doc for generic API Expire method to correctly reflect that the milliseconds argument is milliseconds and not seconds
  • Fixed issue in GetRandom method of SortedSet.
    • I was getting test failures for Test_SortedSet/Test_HandleZRANDMEMBER about 70% out of 10-15 runs. I was able to observe that GetRandom would sometimes return an empty value in one of it's indexes. I narrowed this down to how DeleteFunc operates. I implemented manual index swapping instead, and no longer saw any failures here (checked with about 20 runs).

While testing I observed some strange behavior with test-race. I had two modules fail during test-race, acl and echovault, each on separate runs. There wasn't any sort of traceback provided with either which was strange. For each one, I then attempted to run the tests for that module independently and all tests passed. After running test-race again after each of these failures I received no more failures. However, I tried clearing the testcache and when running make test I started receiving failures on Test_SortedSet/Test_HandleZRANDMEMBER so I debugged that. The other failures I saw no longer popped up.

@kelvinmwinuka kelvinmwinuka merged commit 21e2ca5 into EchoVault:main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants