Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #69
expireAt
unnecessarily in the case of pexpire and pexpireatmilliseconds
argument is milliseconds and not secondsWhile testing I observed some strange behavior with
test-race
. I had two modules fail duringtest-race
, acl and echovault, each on separate runs. There wasn't any sort of traceback provided with either which was strange. For each one, I then attempted to run the tests for that module independently and all tests passed. After runningtest-race
again after each of these failures I received no more failures. However, I tried clearing the testcache and when runningmake test
I started receiving failures on Test_SortedSet/Test_HandleZRANDMEMBER so I debugged that. The other failures I saw no longer popped up.